On 4/7/22 13:16, Laurent Pinchart wrote:
Hi Marek,

Thank you for the patch.

On Fri, Apr 01, 2022 at 06:21:53PM +0200, Marek Vasut wrote:
The mode parsing is currently implemented in three steps:
of_get_display_timing() - DT panel-timing to struct display_timing
videomode_from_timing() - struct display_timing to struct videomode
drm_display_mode_from_videomode() - struct videomode to struct drm_display_mode

Replace all that with simple of_get_drm_panel_display_mode() call,
which already populates struct drm_display_mode and then duplicate
that mode in panel_lvds_get_modes() each time, since the mode does
not change.

Nice bonus is the bus_flags parsed by of_get_drm_panel_display_mode()
out of panel-timing DT node, which is used in subsequent patch to fix
handling of 'de-active' DT property.

Tested-by: Christoph Niedermaier <cniederma...@dh-electronics.com>
Signed-off-by: Marek Vasut <ma...@denx.de>
Cc: Christoph Niedermaier <cniederma...@dh-electronics.com>
Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
Cc: Dmitry Osipenko <dig...@gmail.com>
Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
Cc: Robert Foss <robert.f...@linaro.org>
Cc: Sam Ravnborg <s...@ravnborg.org>
Cc: Thomas Zimmermann <tzimmerm...@suse.de>
To: dri-devel@lists.freedesktop.org

Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>

If that's OK with everyone, I will apply those soon.

Reply via email to