Hi Maxime,

I love your patch! Perhaps something to improve:

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip next-20220503]
[cannot apply to anholt/for-next v5.18-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    
https://github.com/intel-lab-lkp/linux/commits/Maxime-Ripard/drm-vc4-Properly-separate-v3d-on-BCM2711-and-fix-frame-ordering/20220503-201745
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: arc-allyesconfig 
(https://download.01.org/0day-ci/archive/20220503/202205032134.wmmuq85t-...@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # 
https://github.com/intel-lab-lkp/linux/commit/0db44bd12236a0a64cf67bbef6b11df5bbe37134
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review 
Maxime-Ripard/drm-vc4-Properly-separate-v3d-on-BCM2711-and-fix-frame-ordering/20220503-201745
        git checkout 0db44bd12236a0a64cf67bbef6b11df5bbe37134
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 
O=build_dir ARCH=arc SHELL=/bin/bash drivers/gpu/drm/vc4/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/vc4/vc4_crtc.c: In function 'vc4_async_set_fence_cb':
>> drivers/gpu/drm/vc4/vc4_crtc.c:865:57: warning: implicit conversion from 
>> 'enum <anonymous>' to 'enum dma_resv_usage' [-Wenum-conversion]
     865 |         ret = dma_resv_get_singleton(cma_bo->base.resv, false, 
&fence);
         |                                                         ^~~~~


vim +865 drivers/gpu/drm/vc4/vc4_crtc.c

   848  
   849  static int vc4_async_set_fence_cb(struct drm_device *dev,
   850                                    struct vc4_async_flip_state 
*flip_state)
   851  {
   852          struct drm_framebuffer *fb = flip_state->fb;
   853          struct drm_gem_cma_object *cma_bo = drm_fb_cma_get_gem_obj(fb, 
0);
   854          struct vc4_dev *vc4 = to_vc4_dev(dev);
   855          struct dma_fence *fence;
   856          int ret;
   857  
   858          if (!vc4->is_vc5) {
   859                  struct vc4_bo *bo = to_vc4_bo(&cma_bo->base);
   860  
   861                  return vc4_queue_seqno_cb(dev, &flip_state->cb.seqno, 
bo->seqno,
   862                                            
vc4_async_page_flip_seqno_complete);
   863          }
   864  
 > 865          ret = dma_resv_get_singleton(cma_bo->base.resv, false, &fence);
   866          if (ret)
   867                  return ret;
   868  
   869          if (dma_fence_add_callback(fence, &flip_state->cb.fence,
   870                                     vc4_async_page_flip_fence_complete))
   871                  vc4_async_page_flip_fence_complete(fence, 
&flip_state->cb.fence);
   872  
   873          return 0;
   874  }
   875  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Reply via email to