Hi Thomas,
url:
https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/drm-mgag200-Fail-on-I2C-initialization-errors/20220505-234643
base: git://anongit.freedesktop.org/drm/drm drm-next
config: i386-randconfig-m021
(https://download.01.org/0day-ci/archive/20220506/202205061008.eyvqwrst-...@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <l...@intel.com>
Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
smatch warnings:
drivers/gpu/drm/mgag200/mgag200_mode.c:819 mgag200_vga_connector_init() error:
uninitialized symbol 'ret'.
vim +/ret +819 drivers/gpu/drm/mgag200/mgag200_mode.c
81a15b9a65565dc Thomas Zimmermann 2020-05-07 809 static int
mgag200_vga_connector_init(struct mga_device *mdev)
414c453106255b1 Dave Airlie 2012-04-17 810 {
832eddf5d8f4d83 Thomas Zimmermann 2020-06-05 811 struct drm_device *dev
= &mdev->base;
81a15b9a65565dc Thomas Zimmermann 2020-05-07 812 struct mga_connector
*mconnector = &mdev->connector;
81a15b9a65565dc Thomas Zimmermann 2020-05-07 813 struct drm_connector
*connector = &mconnector->base;
81a15b9a65565dc Thomas Zimmermann 2020-05-07 814 struct mga_i2c_chan
*i2c;
81a15b9a65565dc Thomas Zimmermann 2020-05-07 815 int ret;
414c453106255b1 Dave Airlie 2012-04-17 816
81a15b9a65565dc Thomas Zimmermann 2020-05-07 817 i2c =
mgag200_i2c_create(dev);
11682b9fc557a02 Thomas Zimmermann 2022-05-05 818 if (IS_ERR(i2c)) {
11682b9fc557a02 Thomas Zimmermann 2022-05-05 @819 drm_err(dev,
"failed to add DDC bus: %d\n", ret);
^^^
Uninitialized
11682b9fc557a02 Thomas Zimmermann 2022-05-05 820 return
PTR_ERR(i2c);
11682b9fc557a02 Thomas Zimmermann 2022-05-05 821 }
414c453106255b1 Dave Airlie 2012-04-17 822
81a15b9a65565dc Thomas Zimmermann 2020-05-07 823 ret =
drm_connector_init_with_ddc(dev, connector,
9572ae176a10f3b Andrzej Pietrasiewicz 2019-07-26 824
&mga_vga_connector_funcs,
9572ae176a10f3b Andrzej Pietrasiewicz 2019-07-26 825
DRM_MODE_CONNECTOR_VGA,
81a15b9a65565dc Thomas Zimmermann 2020-05-07 826
&i2c->adapter);
81a15b9a65565dc Thomas Zimmermann 2020-05-07 827 if (ret)
81a15b9a65565dc Thomas Zimmermann 2020-05-07 828 goto
err_mgag200_i2c_destroy;
414c453106255b1 Dave Airlie 2012-04-17 829
drm_connector_helper_add(connector, &mga_vga_connector_helper_funcs);
414c453106255b1 Dave Airlie 2012-04-17 830
81a15b9a65565dc Thomas Zimmermann 2020-05-07 831 mconnector->i2c = i2c;
3d5a1c5e300483d Egbert Eich 2013-07-17 832
81a15b9a65565dc Thomas Zimmermann 2020-05-07 833 return 0;
81a15b9a65565dc Thomas Zimmermann 2020-05-07 834
81a15b9a65565dc Thomas Zimmermann 2020-05-07 835 err_mgag200_i2c_destroy:
81a15b9a65565dc Thomas Zimmermann 2020-05-07 836
mgag200_i2c_destroy(i2c);
81a15b9a65565dc Thomas Zimmermann 2020-05-07 837 return ret;
414c453106255b1 Dave Airlie 2012-04-17 838 }
--
0-DAY CI Kernel Test Service
https://01.org/lkp
