[Public] DCN 3.1.6 needs it, but I don't know if yellow carp needs it. I think this is only applicable to kernel 5.18. @Kazlauskas, Nicholas<mailto:nicholas.kazlaus...@amd.com> can you verify?
Alex ________________________________ From: VURDIGERENATARAJ, CHANDAN <chandan.vurdigerenata...@amd.com> Sent: Wednesday, May 18, 2022 8:36 AM To: Sasha Levin <sas...@kernel.org>; linux-ker...@vger.kernel.org <linux-ker...@vger.kernel.org>; sta...@vger.kernel.org <sta...@vger.kernel.org> Cc: Yang, Eric <eric.ya...@amd.com>; haonan.wa...@amd.com <haonan.wa...@amd.com>; Li, Sun peng (Leo) <sunpeng...@amd.com>; Pan, Xinhui <xinhui....@amd.com>; Siqueira, Rodrigo <rodrigo.sique...@amd.com>; amd-...@lists.freedesktop.org <amd-...@lists.freedesktop.org>; Koenig, Christian <christian.koe...@amd.com>; airl...@linux.ie <airl...@linux.ie>; dri-devel@lists.freedesktop.org <dri-devel@lists.freedesktop.org>; dan...@ffwll.ch <dan...@ffwll.ch>; wyatt.w...@amd.com <wyatt.w...@amd.com>; Deucher, Alexander <alexander.deuc...@amd.com>; mikita.lip...@amd.com <mikita.lip...@amd.com>; Wentland, Harry <harry.wentl...@amd.com>; Kazlauskas, Nicholas <nicholas.kazlaus...@amd.com>; Kotarac, Pavle <pavle.kota...@amd.com> Subject: RE: [PATCH AUTOSEL 5.17 13/23] drm/amd/display: undo clearing of z10 related function pointers Hi, Is S0i3 verified for DCN 3.1.6 with this? BR, Chandan V N >From: Eric Yang <eric.ya...@amd.com> > >[ Upstream commit 9b9bd3f640640f94272a461b2dfe558f91b322c5 ] > > [Why] >Z10 and S0i3 have some shared path. Previous code clean up , incorrectly >removed these pointers, which breaks s0i3 restore > > [How] >Do not clear the function pointers based on Z10 disable. > >Reviewed-by: Nicholas Kazlauskas <nicholas.kazlaus...@amd.com> >Acked-by: Pavle Kotarac <pavle.kota...@amd.com> >Signed-off-by: Eric Yang <eric.ya...@amd.com> >Signed-off-by: Alex Deucher <alexander.deuc...@amd.com> >Signed-off-by: Sasha Levin <sas...@kernel.org> >--- > drivers/gpu/drm/amd/display/dc/dcn31/dcn31_init.c | 5 ----- > 1 file changed, 5 deletions(-) > >diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_init.c >b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_init.c >index d7559e5a99ce..e708f07fe75a 100644 >--- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_init.c >+++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_init.c >@@ -153,9 +153,4 @@ void dcn31_hw_sequencer_construct(struct dc *dc) > dc->hwss.init_hw = dcn20_fpga_init_hw; > dc->hwseq->funcs.init_pipes = NULL; > } >- if (dc->debug.disable_z10) { >- /*hw not support z10 or sw disable it*/ >- dc->hwss.z10_restore = NULL; >- dc->hwss.z10_save_init = NULL; >- } > } >-- >2.35.1 >