On 2022-06-10 12:01:10, Stephen Boyd wrote: > Quoting Marijn Suijten (2022-06-10 00:46:32) > > On 2022-06-09 15:12:09, Stephen Boyd wrote: > > > Quoting Dmitry Baryshkov (2022-06-02 03:20:19) > > > > On Thu, 2 Jun 2022 at 01:07, Marijn Suijten > > > > <[email protected]> wrote: > > > > > diff --git a/drivers/clk/clk-fixed-factor.c > > > > > b/drivers/clk/clk-fixed-factor.c > > > > > index 54942d758ee6..fabb98d0cdb2 100644 > > > > > --- a/drivers/clk/clk-fixed-factor.c > > > > > +++ b/drivers/clk/clk-fixed-factor.c > > > > > @@ -148,17 +151,50 @@ struct clk_hw > > > > > *devm_clk_hw_register_fixed_factor_index(struct device *dev, > > > > > const char *name, unsigned int index, unsigned long > > > > > flags, > > > > > unsigned int mult, unsigned int div) > > > > > { > > > > > - return __clk_hw_register_fixed_factor(dev, NULL, name, NULL, > > > > > index, > > > > > - flags, mult, div, true); > > > > > + return __clk_hw_register_fixed_factor(dev, NULL, name, NULL, > > > > > NULL, > > > > > + index, flags, mult, > > > > > div, true); > > > > > > > > Here (and several times later) you are inserting an argument and then > > > > moving arguments to the next line. My slight preference would be to > > > > just insert the arg (and maybe break the line if it gets too long) w/o > > > > touching the next lines. > > > > That'll definitely look odd, as we'll end up with index floating on a > > single line, all on its own. > > Pretty sure Dmitry is suggesting to make the line longer, not put the > index on a line by itself. Ignore the 80-column limit.
There's a "(and maybe break the line if it gets too long)" in there, but it's ugly especially for short (ie. "0,") arguments. I'm following your request to ignore 80-columns as a limit. Will resend this after being able to physically build-test it tomorrow, thanks! - Marijn
