On 06/09/2022 20:52, Chris Morgan wrote: > From: Chris Morgan <[email protected]> > > Add documentation for the NewVision NV3051D panel bindings. > Note that for the two expected consumers of this panel binding > the underlying LCD model is unknown. > > Signed-off-by: Chris Morgan <[email protected]> > --- > .../display/panel/newvision,nv3051d.yaml | 48 +++++++++++++++++++ > 1 file changed, 48 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > > diff --git > a/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > new file mode 100644 > index 000000000000..016168d8d7b2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml > @@ -0,0 +1,48 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/panel/newvision,nv3051d.yaml#
You need to document vendor prefix... but the filename does not match compatible. > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NewVision NV3051D based DSI panel driver This is confusing - compatibles say something else. > + > +maintainers: > + - Chris Morgan <[email protected]> > + > +allOf: > + - $ref: panel-common.yaml# > + > +properties: > + compatible: > + enum: > + - anbernic,rg353p-panel > + - anbernic,rg353v-panel Missing space, missing documentation for vendor prefix. Strip "panel" suffix unless device is multifunctional. > + reg: true > + backlight: true Best regards, Krzysztof
