On Sat, Sep 24, 2022 at 05:52:29PM +0200, Noralf Trønnes wrote: > Den 22.09.2022 16.25, skrev Maxime Ripard: > > The TV mode property has been around for a while now to select and get the > > current TV mode output on an analog TV connector. > > > > Despite that property name being generic, its content isn't and has been > > driver-specific which makes it hard to build any generic behaviour on top > > of it, both in kernel and user-space. > > > > Let's create a new enum tv norm property, that can contain any of the > > analog TV standards currently supported by kernel drivers. Each driver can > > then pass in a bitmask of the modes it supports, and the property > > creation function will filter out the modes not supported. > > > > We'll then be able to phase out the older tv mode property. > > > > Signed-off-by: Maxime Ripard <max...@cerno.tech> > > Please can you add per patch changelogs, it's hard to review when I have > to recall what might have happened with each patch. If you do it drm > style and put in the commit message it should be easy enough to do.
I certainly don't want to start that discussion, but I'm really not a
fan of that format either. I'll do it for that series if you prefer.
> > +/**
> > + * enum drm_connector_tv_mode - Analog TV output mode
> > + *
> > + * This enum is used to indicate the TV output mode used on an analog TV
> > + * connector.
> > + *
> > + * WARNING: The values of this enum is uABI since they're exposed in the
> > + * "TV mode" connector property.
> > + */
> > +enum drm_connector_tv_mode {
> > + /**
> > + * @DRM_MODE_TV_MODE_NONE: Placeholder to not default on one
> > + * variant or the other when nothing is set.
> > + */
> > + DRM_MODE_TV_MODE_NONE = 0,
>
> How is this supposed to be used?
It's not supposed to be used. It was a suggestion from Mateusz to avoid
to default to any standard when we don't initialize something. I don't
have any strong feeling about it, so I can drop it if you prefer.
Maxime
signature.asc
Description: PGP signature
