On Thu, Oct 20, 2022 at 8:57 PM Maciej Kwapulinski <maciej.kwapulin...@linux.intel.com> wrote: > > drm_gem_shmem_object is base for memory objects provided by the patch
Here and in some other commit messages don't forget English punctuation, like trailing period. ... > +struct gna_gem_object { > + struct drm_gem_shmem_object base; > + > + uint32_t handle; Not u32 or __u32? Is it a subsystem requirement to have uint32_t? Or your driver, then why are you not using similar types elsewhere? > +}; -- With Best Regards, Andy Shevchenko