Add a dependency on CONFIG_MMU to ofdrm. The driver uses GEM SHMEM
helpers, which require MMU support. A reported error message [1] is
shown below.

   arm-linux-gnueabi-ld: drivers/gpu/drm/drm_gem_shmem_helper.o: in function 
`drm_gem_shmem_fault':
   >> drivers/gpu/drm/drm_gem_shmem_helper.c:562: undefined reference to 
`vmf_insert_pfn'

Reported-by: kernel test robot <l...@intel.com>
Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
Fixes: c8a17756c425 ("drm/ofdrm: Add ofdrm for Open Firmware framebuffers")
Cc: Thomas Zimmermann <tzimmerm...@suse.de>
Cc: Javier Martinez Canillas <javi...@redhat.com>
Cc: Sam Ravnborg <s...@ravnborg.org>
Cc: Maxime Ripard <max...@cerno.tech>
Cc: "Noralf Trønnes" <nor...@tronnes.org>
Cc: Danilo Krummrich <d...@redhat.com>
Cc: Michal Suchanek <msucha...@suse.de>
Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
Link: https://lore.kernel.org/dri-devel/202210192029.zfejvqjv-...@intel.com/ # 
[1]
---
 drivers/gpu/drm/tiny/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tiny/Kconfig b/drivers/gpu/drm/tiny/Kconfig
index a300b03a3c7a7..f6889f649bc18 100644
--- a/drivers/gpu/drm/tiny/Kconfig
+++ b/drivers/gpu/drm/tiny/Kconfig
@@ -53,7 +53,7 @@ config DRM_GM12U320
 
 config DRM_OFDRM
        tristate "Open Firmware display driver"
-       depends on DRM && OF && (PPC || COMPILE_TEST)
+       depends on DRM && MMU && OF && (PPC || COMPILE_TEST)
        select APERTURE_HELPERS
        select DRM_GEM_SHMEM_HELPER
        select DRM_KMS_HELPER
-- 
2.38.0

Reply via email to