Am 10.11.22 um 15:33 schrieb Dong Chenchen:
When p->gang_size equals 0, amdgpu_cs_pass1() will return directly without freeing chunk_array, which will cause a memory leak issue, this patch fixes it.Fixes: 4624459c84d7 ("drm/amdgpu: add gang submit frontend v6") Signed-off-by: Dong Chenchen <[email protected]>
Good catch, thanks. Patch is Reviewed-by: Christian König <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c index 1bbd39b3b0fc..0e24d6b80e0b 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c @@ -287,8 +287,10 @@ static int amdgpu_cs_pass1(struct amdgpu_cs_parser *p, } }- if (!p->gang_size)- return -EINVAL; + if (!p->gang_size) { + ret = -EINVAL; + goto free_partial_kdata; + }for (i = 0; i < p->gang_size; ++i) {ret = amdgpu_job_alloc(p->adev, num_ibs[i], &p->jobs[i], vm);
