Le 07/01/2023 à 19:26, Sam Ravnborg via B4 Submission Endpoint a écrit : > From: Sam Ravnborg <[email protected]> > > Introduce backlight_get_brightness() to simplify logic > and avoid direct access to backlight properties.
When I read 'introduce' I understand that you are adding a new function. In fact backlight_get_brightness() already exists, so maybe replace 'introduce' by 'use' > > Signed-off-by: Sam Ravnborg <[email protected]> > Cc: Bartlomiej Zolnierkiewicz <[email protected]> > Cc: Sam Ravnborg <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: Souptick Joarder <[email protected]> > Cc: Maarten Lankhorst <[email protected]> > Cc: Jason Yan <[email protected]> > Cc: Jani Nikula <[email protected]> > Cc: Arnd Bergmann <[email protected]> > --- > drivers/video/fbdev/aty/atyfb_base.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/video/fbdev/aty/atyfb_base.c > b/drivers/video/fbdev/aty/atyfb_base.c > index 0ccf5d401ecb..ca361e215904 100644 > --- a/drivers/video/fbdev/aty/atyfb_base.c > +++ b/drivers/video/fbdev/aty/atyfb_base.c > @@ -2219,13 +2219,7 @@ static int aty_bl_update_status(struct > backlight_device *bd) > { > struct atyfb_par *par = bl_get_data(bd); > unsigned int reg = aty_ld_lcd(LCD_MISC_CNTL, par); > - int level; > - > - if (bd->props.power != FB_BLANK_UNBLANK || > - bd->props.fb_blank != FB_BLANK_UNBLANK) > - level = 0; > - else > - level = bd->props.brightness; > + int level = backlight_get_brightness(bd); > > reg |= (BLMOD_EN | BIASMOD_EN); > if (level > 0) { > > -- > 2.34.1
