This code accidentally returns the wrong variable (which is
uninitialized).  It should return ret.

Fixes: a309c7194e8a ("drm/vmwgfx: Remove rcu locks from user resources")
Signed-off-by: Dan Carpenter <[email protected]>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 +-
 drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c 
b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
index 9359e8dfbac2..0ee30a1aa23d 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
@@ -1156,7 +1156,7 @@ static int vmw_translate_mob_ptr(struct vmw_private 
*dev_priv,
        ret = vmw_user_bo_lookup(sw_context->filp, handle, &vmw_bo);
        if (ret != 0) {
                drm_dbg(&dev_priv->drm, "Could not find or use MOB buffer.\n");
-               return PTR_ERR(vmw_bo);
+               return ret;
        }
        ret = vmw_validation_add_bo(sw_context->ctx, vmw_bo, true, false);
        ttm_bo_put(&vmw_bo->base);
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c 
b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
index 0ee30a1aa23d..fa3761b3e956 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c
@@ -1210,7 +1210,7 @@ static int vmw_translate_guest_ptr(struct vmw_private 
*dev_priv,
        ret = vmw_user_bo_lookup(sw_context->filp, handle, &vmw_bo);
        if (ret != 0) {
                drm_dbg(&dev_priv->drm, "Could not find or use GMR region.\n");
-               return PTR_ERR(vmw_bo);
+               return ret;
        }
        ret = vmw_validation_add_bo(sw_context->ctx, vmw_bo, false, false);
        ttm_bo_put(&vmw_bo->base);
-- 
2.35.1

Reply via email to