Re: [PATCH 2/2] accel/ivpu: avoid duplciate assignment

[Thomas Zimmermann]

Am 31.01.23 um 15:00 schrieb Jacek Lawrynowicz:

Applied to drm-misc-next. Thanks.

I have cherry-picked the patch into drm-misc-next-fixes.

On 26.01.2023 17:37, Arnd Bergmann wrote:

From: Arnd Bergmann <a...@arndb.de>

With extra warnings enabled, gcc warns about two assignments
of the same .mmap callback:

In file included from drivers/accel/ivpu/ivpu_drv.c:10:
include/drm/drm_accel.h:31:27: error: initialized field overwritten 
[-Werror=override-init]
    31 |         .mmap           = drm_gem_mmap
       |                           ^~~~~~~~~~~~
drivers/accel/ivpu/ivpu_drv.c:360:9: note: in expansion of macro 
'DRM_ACCEL_FOPS'
   360 |         DRM_ACCEL_FOPS,
       |         ^~~~~~~~~~~~~~

Remove the unused local assignment.

Fixes: 20709aa9435b ("accel: Add .mmap to DRM_ACCEL_FOPS")
Signed-off-by: Arnd Bergmann <a...@arndb.de>
---
  drivers/accel/ivpu/ivpu_drv.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu/ivpu_drv.c
index 2bc2f1b90671..a29e8ee0dce6 100644
--- a/drivers/accel/ivpu/ivpu_drv.c
+++ b/drivers/accel/ivpu/ivpu_drv.c
@@ -356,7 +356,6 @@ int ivpu_shutdown(struct ivpu_device *vdev)

        .owner          = THIS_MODULE,
-       .mmap           = drm_gem_mmap,
        DRM_ACCEL_FOPS,
  };

static const struct file_operations ivpu_fops = {

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

OpenPGP_signature
Description: OpenPGP digital signature