Hi Dmitry, I love your patch! Perhaps something to improve:
[auto build test WARNING on drm-misc/drm-misc-next] [also build test WARNING on drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm/drm-next v6.2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Dmitry-Baryshkov/drm-i915-dsc-change-DSC-param-tables-to-follow-the-DSC-model/20230228-193505 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20230228113342.2051425-4-dmitry.baryshkov%40linaro.org patch subject: [PATCH 03/10] drm/i915/dsc: move DSC tables to DRM DSC helper config: x86_64-randconfig-a002-20230227 (https://download.01.org/0day-ci/archive/20230228/202302282241.qrmajdx8-...@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/ee048cb6c2ec7f7f92bea6b72e8cd3ef9921993e git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Dmitry-Baryshkov/drm-i915-dsc-change-DSC-param-tables-to-follow-the-DSC-model/20230228-193505 git checkout ee048cb6c2ec7f7f92bea6b72e8cd3ef9921993e # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/display/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <l...@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202302282241.qrmajdx8-...@intel.com/ All warnings (new ones prefixed by >>): >> drivers/gpu/drm/display/drm_dsc_helper.c:635: warning: expecting prototype >> for drm_dsc_compute_rc_parameters(). Prototype was for >> drm_dsc_setup_rc_params() instead vim +635 drivers/gpu/drm/display/drm_dsc_helper.c 627 628 /** 629 * drm_dsc_compute_rc_parameters() - Set parameters and limits for RC model in 630 * accordance with the DSC 1.1 or 1.2 specification and DSC C Model 631 * 632 * @vdsc_cfg: DSC Configuration data partially filled by driver 633 */ 634 int drm_dsc_setup_rc_params(struct drm_dsc_config *vdsc_cfg) > 635 { 636 const struct rc_parameters *rc_params; 637 int i; 638 639 /* fractional BPP is not supported */ 640 if (vdsc_cfg->bits_per_pixel & 0xf) 641 return -EINVAL; 642 643 rc_params = get_rc_params(vdsc_cfg->bits_per_pixel >> 4, 644 vdsc_cfg->bits_per_component); 645 if (!rc_params) 646 return -EINVAL; 647 648 vdsc_cfg->first_line_bpg_offset = rc_params->first_line_bpg_offset; 649 vdsc_cfg->initial_xmit_delay = rc_params->initial_xmit_delay; 650 vdsc_cfg->initial_offset = rc_params->initial_offset; 651 vdsc_cfg->flatness_min_qp = rc_params->flatness_min_qp; 652 vdsc_cfg->flatness_max_qp = rc_params->flatness_max_qp; 653 vdsc_cfg->rc_quant_incr_limit0 = rc_params->rc_quant_incr_limit0; 654 vdsc_cfg->rc_quant_incr_limit1 = rc_params->rc_quant_incr_limit1; 655 656 for (i = 0; i < DSC_NUM_BUF_RANGES; i++) { 657 vdsc_cfg->rc_range_params[i].range_min_qp = 658 rc_params->rc_range_params[i].range_min_qp; 659 vdsc_cfg->rc_range_params[i].range_max_qp = 660 rc_params->rc_range_params[i].range_max_qp; 661 /* 662 * Range BPG Offset uses 2's complement and is only a 6 bits. So 663 * mask it to get only 6 bits. 664 */ 665 vdsc_cfg->rc_range_params[i].range_bpg_offset = 666 rc_params->rc_range_params[i].range_bpg_offset & 667 DSC_RANGE_BPG_OFFSET_MASK; 668 } 669 670 return 0; 671 } 672 EXPORT_SYMBOL(drm_dsc_setup_rc_params); 673 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
