The drm_rect_intersect() already returns if the intersection is visible or not, so the use of drm_rect_visible() is duplicate.
Signed-off-by: Arthur Grillo <arthurgri...@riseup.net> --- v1->v2: https://lore.kernel.org/all/20230324142533.6357-1-arthurgri...@riseup.net/ - Split the if condition. --- drivers/gpu/drm/i915/display/intel_overlay.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_overlay.c b/drivers/gpu/drm/i915/display/intel_overlay.c index c12bdca8da9b..d55153587cae 100644 --- a/drivers/gpu/drm/i915/display/intel_overlay.c +++ b/drivers/gpu/drm/i915/display/intel_overlay.c @@ -966,10 +966,11 @@ static int check_overlay_dst(struct intel_overlay *overlay, rec->dst_width, rec->dst_height); clipped = req; - drm_rect_intersect(&clipped, &crtc_state->pipe_src); - if (!drm_rect_visible(&clipped) || - !drm_rect_equals(&clipped, &req)) + if (!drm_rect_intersect(&clipped, &crtc_state->pipe_src)) + return -EINVAL; + + if (!drm_rect_equals(&clipped, &req)) return -EINVAL; return 0; -- 2.39.2
