On Mon, 10 Apr 2023 at 22:28, Stephen Boyd <[email protected]> wrote: > > Quoting Dmitry Baryshkov (2023-04-08 18:13:29) > > The commit 010c8bbad2cb ("drm: msm: adreno: Disable preemption on Adreno > > 510") added special handling for a510 (this SKU doesn't seem to support > > preemption, so the driver should clamp nr_rings to 1). However the > > gpu->revn is not yet set (it is set later, in adreno_gpu_init()) and > > thus the condition is always false. Check config->rev instead. > > > > Fixes: 010c8bbad2cb ("drm: msm: adreno: Disable preemption on Adreno 510") > > Reported-by: Adam Skladowski <[email protected]> > > Signed-off-by: Dmitry Baryshkov <[email protected]> > > --- > > Maybe as a followup you can put a WARN_ON_ONCE() inside a new function > that gets gpu->revn and warns if the value is 0?
Sounds like a good idea. -- With best wishes Dmitry
