[AMD Official Use Only - General] (Adding Felix in CC)
I’m a fan of adding it to KFD as well. Felix, can you foresee any issues here? Kent From: amd-gfx <amd-gfx-boun...@lists.freedesktop.org> On Behalf Of Ho, Kenny Sent: Wednesday, May 24, 2023 3:23 PM To: Alex Deucher <alexdeuc...@gmail.com>; Mahfooz, Hamza <hamza.mahf...@amd.com> Cc: Li, Sun peng (Leo) <sunpeng...@amd.com>; Wentland, Harry <harry.wentl...@amd.com>; Pan, Xinhui <xinhui....@amd.com>; Siqueira, Rodrigo <rodrigo.sique...@amd.com>; linux-ker...@vger.kernel.org; dri-devel@lists.freedesktop.org; amd-...@lists.freedesktop.org; Daniel Vetter <dan...@ffwll.ch>; Deucher, Alexander <alexander.deuc...@amd.com>; David Airlie <airl...@gmail.com>; Koenig, Christian <christian.koe...@amd.com> Subject: Re: [PATCH v2] drm/amd/display: enable more strict compile checks [AMD Official Use Only - General] [AMD Official Use Only - General] (+ Felix) Should we do the same for other modules under amd (amdkfd)? I was going to enable full kernel werror in the kconfig used by my CI but this is probably better. Kenny ________________________________ From: Alex Deucher <alexdeuc...@gmail.com<mailto:alexdeuc...@gmail.com>> Sent: Wednesday, May 24, 2023 3:22 PM To: Mahfooz, Hamza <hamza.mahf...@amd.com<mailto:hamza.mahf...@amd.com>> Cc: amd-...@lists.freedesktop.org<mailto:amd-...@lists.freedesktop.org> <amd-...@lists.freedesktop.org<mailto:amd-...@lists.freedesktop.org>>; Li, Sun peng (Leo) <sunpeng...@amd.com<mailto:sunpeng...@amd.com>>; Ho, Kenny <kenny...@amd.com<mailto:kenny...@amd.com>>; Pan, Xinhui <xinhui....@amd.com<mailto:xinhui....@amd.com>>; Siqueira, Rodrigo <rodrigo.sique...@amd.com<mailto:rodrigo.sique...@amd.com>>; linux-ker...@vger.kernel.org<mailto:linux-ker...@vger.kernel.org> <linux-ker...@vger.kernel.org<mailto:linux-ker...@vger.kernel.org>>; dri-devel@lists.freedesktop.org<mailto:dri-devel@lists.freedesktop.org> <dri-devel@lists.freedesktop.org<mailto:dri-devel@lists.freedesktop.org>>; Daniel Vetter <dan...@ffwll.ch<mailto:dan...@ffwll.ch>>; Deucher, Alexander <alexander.deuc...@amd.com<mailto:alexander.deuc...@amd.com>>; David Airlie <airl...@gmail.com<mailto:airl...@gmail.com>>; Wentland, Harry <harry.wentl...@amd.com<mailto:harry.wentl...@amd.com>>; Koenig, Christian <christian.koe...@amd.com<mailto:christian.koe...@amd.com>> Subject: Re: [PATCH v2] drm/amd/display: enable more strict compile checks On Wed, May 24, 2023 at 3:20 PM Hamza Mahfooz <hamza.mahf...@amd.com<mailto:hamza.mahf...@amd.com>> wrote: > > Currently, there are quite a number of issues that are quite easy for > the CI to catch, that slip through the cracks. Among them, there are > unused variable and indentation issues. Also, we should consider all > warnings to be compile errors, since the community will eventually end > up complaining about them. So, enable -Werror, -Wunused and > -Wmisleading-indentation for all kernel builds. > > Cc: Alex Deucher <alexander.deuc...@amd.com<mailto:alexander.deuc...@amd.com>> > Cc: Harry Wentland <harry.wentl...@amd.com<mailto:harry.wentl...@amd.com>> > Cc: Kenny Ho <kenny...@amd.com<mailto:kenny...@amd.com>> > Signed-off-by: Hamza Mahfooz > <hamza.mahf...@amd.com<mailto:hamza.mahf...@amd.com>> > --- > v2: fix grammatical error > --- > drivers/gpu/drm/amd/display/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/display/Makefile > b/drivers/gpu/drm/amd/display/Makefile > index 0d610cb376bb..3c44162ebe21 100644 > --- a/drivers/gpu/drm/amd/display/Makefile > +++ b/drivers/gpu/drm/amd/display/Makefile > @@ -26,6 +26,8 @@ > > AMDDALPATH = $(RELATIVE_AMD_DISPLAY_PATH) > > +subdir-ccflags-y += -Werror -Wunused -Wmisleading-indentation > + Care to enable this for the rest of amdgpu as well? Or send out an additional patch to do that? Either way: Reviewed-by: Alex Deucher <alexander.deuc...@amd.com<mailto:alexander.deuc...@amd.com>> Alex > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/ > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/inc/hw > subdir-ccflags-y += -I$(FULL_AMD_DISPLAY_PATH)/dc/clk_mgr > -- > 2.40.1 >
