Hi Marek, On Thu, Jun 15, 2023 at 10:18:58PM +0200, Marek Vasut wrote: > Move the register programming part, which actually enables the bridge and > makes it push data out of its DPI side, into the enable callback. The DSI > host like DSIM may not be able to transmit commands in pre_enable, moving > the register programming into enable assures it can transmit commands. > > Signed-off-by: Marek Vasut <[email protected]>
I was about to complain that the use of .enable is deprecated, but the following patch fixes this. So: Reviewed-by: Sam Ravnborg <[email protected]> > --- > Cc: Andrzej Hajda <[email protected]> > Cc: Daniel Vetter <[email protected]> > Cc: David Airlie <[email protected]> > Cc: Jernej Skrabec <[email protected]> > Cc: Jonas Karlman <[email protected]> > Cc: Laurent Pinchart <[email protected]> > Cc: Neil Armstrong <[email protected]> > Cc: Robert Foss <[email protected]> > Cc: [email protected] > --- > drivers/gpu/drm/bridge/tc358762.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/tc358762.c > b/drivers/gpu/drm/bridge/tc358762.c > index 5641395fd310e..df9703eacab1f 100644 > --- a/drivers/gpu/drm/bridge/tc358762.c > +++ b/drivers/gpu/drm/bridge/tc358762.c > @@ -162,11 +162,17 @@ static void tc358762_pre_enable(struct drm_bridge > *bridge) > usleep_range(5000, 10000); > } > > + ctx->pre_enabled = true; > +} > + > +static void tc358762_enable(struct drm_bridge *bridge) > +{ > + struct tc358762 *ctx = bridge_to_tc358762(bridge); > + int ret; > + > ret = tc358762_init(ctx); > if (ret < 0) > dev_err(ctx->dev, "error initializing bridge (%d)\n", ret); > - > - ctx->pre_enabled = true; > } > > static int tc358762_attach(struct drm_bridge *bridge, > @@ -181,6 +187,7 @@ static int tc358762_attach(struct drm_bridge *bridge, > static const struct drm_bridge_funcs tc358762_bridge_funcs = { > .post_disable = tc358762_post_disable, > .pre_enable = tc358762_pre_enable, > + .enable = tc358762_enable, > .attach = tc358762_attach, > }; > > -- > 2.39.2
