Re: [PATCH 01/12] drm/msm/adreno: Remove GPU name

[Konrad Dybcio]

On 6.07.2023 23:10, Rob Clark wrote:
> From: Rob Clark <robdcl...@chromium.org>
> 
> No real need to have marketing names in the kernel.
> 
> Signed-off-by: Rob Clark <robdcl...@chromium.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dyb...@linaro.org>

[...]

> -     gpu_name = adreno_gpu->info->name;
> -     if (!gpu_name) {
> -             gpu_name = devm_kasprintf(dev, GFP_KERNEL, "%d.%d.%d.%d",
> -                             rev->core, rev->major, rev->minor,
> -                             rev->patchid);
> -             if (!gpu_name)
> -                     return -ENOMEM;
> -     }
> +     gpu_name = devm_kasprintf(dev, GFP_KERNEL, "%d.%d.%d.%d",
> +                     rev->core, rev->major, rev->minor,
> +                     rev->patchid);
nit: great opportunity to align indentation with the opening brace

Konrad
> +     if (!gpu_name)
> +             return -ENOMEM;
>  
>       adreno_gpu_config.ioname = "kgsl_3d0_reg_memory";
>  
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.h 
> b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
> index cf45007400c8..6830c3776c2d 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.h
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.h
> @@ -61,7 +61,6 @@ extern const struct adreno_reglist a660_hwcg[], a690_hwcg[];
>  struct adreno_info {
>       struct adreno_rev rev;
>       uint32_t revn;
> -     const char *name;
>       const char *fw[ADRENO_FW_MAX];
>       uint32_t gmem;
>       u64 quirks;