On Thu, Jul 13, 2023 at 10:59 AM Javier Martinez Canillas <[email protected]> wrote: > The commit e254b584dbc0 ("drm/ssd130x: Remove hardcoded bits-per-pixel in > ssd130x_buf_alloc()") used a pixel format info instead of a hardcoded bpp > to calculate the size of the buffer allocated to store the native pixels. > > But that wrongly used the DRM_FORMAT_C1 fourcc pixel format, which is for > color-indexed frame buffer formats. While the ssd103x controllers don't > support different single-channel colors nor a Color Lookup Table (CLUT). > > Both formats use eight pixels/byte, so in practice there is no functional > changes in this patch. But still the correct pixel format should be used. > > Suggested-by: Geert Uytterhoeven <[email protected]> > Signed-off-by: Javier Martinez Canillas <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected] In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
