On 19.07.23 09:51, Kefeng Wang wrote:
Use the helpers to simplify code.

Cc: Felix Kuehling <felix.kuehl...@amd.com>
Cc: Alex Deucher <alexander.deuc...@amd.com>
Cc: "Christian König" <christian.koe...@amd.com>
Cc: "Pan, Xinhui" <xinhui....@amd.com>
Cc: David Airlie <airl...@gmail.com>
Cc: Daniel Vetter <dan...@ffwll.ch>
Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com>
---
  drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 5 +----
  1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c 
b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index 5ff1a5a89d96..0b7bfbd0cb66 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -2621,10 +2621,7 @@ svm_range_get_range_boundaries(struct kfd_process *p, 
int64_t addr,
                return -EFAULT;
        }
- *is_heap_stack = (vma->vm_start <= vma->vm_mm->brk &&
-                         vma->vm_end >= vma->vm_mm->start_brk) ||
-                        (vma->vm_start <= vma->vm_mm->start_stack &&
-                         vma->vm_end >= vma->vm_mm->start_stack);
+       *is_heap_stack = vma_is_initial_heap(vma) || vma_is_initial_stack(vma);
start_limit = max(vma->vm_start >> PAGE_SHIFT,
                      (unsigned long)ALIGN_DOWN(addr, 2UL << 8));

Certainly a valid refactoring, although questionable if such code should care about that.

Reviewed-by: David Hildenbrand <da...@redhat.com>

--
Cheers,

David / dhildenb

Reply via email to