On Wed, Jul 19, 2023 at 05:42:54AM +0000, Kasireddy, Vivek wrote:
> > > +                 } else {
> > > +                         page =
> > shmem_read_mapping_page(mapping, pgoff + pgidx);
> > 
> > It may not matter to your users, but the semantics for hugetlb and shmem
> > pages is different.  hugetlb requires the pages exist in the page cache
> > while shmem will create/add pages to the cache if necessary.
> Ok; got it.

Would it be nice to do the same for both (perhaps always try to allocate)?

Thanks,

-- 
Peter Xu

Reply via email to