On Thu, Aug 31, 2023 at 10:47:24AM +0000, Biju Das wrote: > > On Thu, Aug 31, 2023 at 09:09:38AM +0100, Biju Das wrote:
... > > > Drop unnecessary CONFIG_OF conditional around devm_drm_of_get_bridge() > > > and > > > drmm_of_get_bridge() as it is guarded with #if..#else blocks in > > > drm_bridge.h. > > > > This will increase the kernel size on non-OF system, to add functions that > > are not used. I don't think the #ifdef here is problematic. > > OK agreed. I guess for NON-OF system it will give build error > for function redefinition, if that is the case I would like to > drop this patch. > > static inline struct drm_bridge *devm_drm_of_get_bridge() > > vs > > struct drm_bridge *devm_drm_of_get_bridge() Yeah, yet another argument in favour of switching to fwnode. -- With Best Regards, Andy Shevchenko
