Thanks for the feedback Bagas,
"Then checkpatch is wrong, " lol
Ill double check my SoB.
Angus
On Wed, Sep 13, 2023 at 11:32 AM Bagas Sanjaya <bagasdo...@gmail.com> wrote:
> On Wed, Sep 13, 2023 at 11:02:13AM +1000, Angus Gardner wrote:
> > ---
> > drivers/staging/fbtft/fb_ra8875.c | 11 ++++-------
> > 1 file changed, 4 insertions(+), 7 deletions(-)
>
> No patch description and SoB, so Greg can't take this as-is.
>
> > - if ((par->info->var.xres == 320) && (par->info->var.yres == 240)) {
> > + if (par->info->var.xres == 320 && par->info->var.yres == 240) {
>
> Greg prefers explicit parentheses on complex expressions (see [1] and [2]
> for examples), hence NAK.
>
> Thanks.
>
> [1]: https://lore.kernel.org/linux-staging/zcwgozqdh1kwt...@kroah.com/
> [2]: https://lore.kernel.org/linux-staging/y%2fiaytkk4vsok...@kroah.com/
>
> --
> An old man doll... just what I always wanted! - Clara
>
