On Tue, 26 Sep 2023, Uwe Kleine-König wrote: > On Tue, Sep 26, 2023 at 10:46:12AM +0200, Uwe Kleine-König wrote: > > Since commit 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once > > per backlight toggle") calling pwm_backlight_power_off() doesn't disable > > the PWM any more. However this is necessary to suspend because PWM > > drivers usually refuse to suspend if they are still enabled. > > > > Also adapt shutdown to disable the PWM for similar reasons. > > > > Fixes: 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once per > > backlight toggle") > > Reported-by: Aisheng Dong <aisheng.d...@nxp.com> > > Tested-by: Aisheng Dong <asheng.d...@nxp.com> > > The two email addresses should actually be identical, the first one is > the right one. (Failure introduced by > https://lore.kernel.org/dri-devel/db9pr04mb8477d4bbf1b31035789da08680...@db9pr04mb8477.eurprd04.prod.outlook.com > and picked up by b4.) Lee, can you fixup or should I resend?
I'll probably forget by the time Daniel gets around to review. Your call, but probably safer to turn it around yourself. -- Lee Jones [李琼斯]