Hi Am 28.11.23 um 09:27 schrieb Maxime Ripard:
Hi,On Mon, Nov 27, 2023 at 10:25:38PM +0100, Marek Vasut wrote:Switch from deprecated unmanaged drm_mode_config_init() to managed drmm_mode_config_init(). No functional change. Signed-off-by: Marek Vasut <[email protected]> --- Cc: Daniel Vetter <[email protected]> Cc: David Airlie <[email protected]> Cc: Fabio Estevam <[email protected]> Cc: Maarten Lankhorst <[email protected]> Cc: Maxime Ripard <[email protected]> Cc: NXP Linux Team <[email protected]> Cc: Pengutronix Kernel Team <[email protected]> Cc: Sascha Hauer <[email protected]> Cc: Shawn Guo <[email protected]> Cc: Stefan Agner <[email protected]> Cc: Thomas Zimmermann <[email protected]> Cc: [email protected] Cc: [email protected]This is only somewhat related to that patch, but mksfb_drm_private is allocated with devm and holds the planes, crtcs and encoders. This is unsafe, leads to UAF, and should be converted to a drmm allocation too (in another patch of course)
To add to this, the whole driver's probe/remove should be converted to managed code. There's irq and pm code that could likely be updated. Marek, if you have the means, patches are welcome.
Best regards Thomas
Maxime
-- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstrasse 146, 90461 Nuernberg, Germany GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman HRB 36809 (AG Nuernberg)
OpenPGP_signature.asc
Description: OpenPGP digital signature
