On Fri, 1 Dec 2023 at 02:50, Abhinav Kumar <[email protected]> wrote: > > > > On 8/30/2023 5:24 PM, Dmitry Baryshkov wrote: > > On Thu, 31 Aug 2023 at 01:50, Abhinav Kumar <[email protected]> > > wrote: > >> > >> On chipsets where CDM block is not available OR where support has > >> not been added yet do not allow YUV formats for writeback block. > >> > >> Signed-off-by: Abhinav Kumar <[email protected]> > >> --- > >> drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c > >> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c > >> index 7fc174b33ae2..d8edca9bc964 100644 > >> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c > >> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_wb.c > >> @@ -406,6 +406,12 @@ static int dpu_encoder_phys_wb_atomic_check( > >> return ret; > >> } > >> > >> + if (DPU_FORMAT_IS_YUV(to_dpu_format(msm_framebuffer_format(fb))) && > >> + !phys_enc->dpu_kms->catalog->cdm) { > >> + DPU_ERROR("cannot support YUV formats without CDM > >> block\n"); > >> + return -EINVAL; > >> + } > > > > Can we have YUV formats in wb_formats if we do not support CDM? That > > would be an error. > > I can drop this one once i address the comments on the next patch. > > Yeah the reason for this change was we had one formats array for wb and > were using that for all chipsets. We can have two arrays : one only rgb > and the other rgb+yuv to address this.
Yes, this sounds fine to me. -- With best wishes Dmitry
