We have a temporary variable to keep pointer to struct device.
Utilise it where it makes sense.

Signed-off-by: Andy Shevchenko <andriy.shevche...@linux.intel.com>
---
 drivers/video/backlight/mp3309c.c | 38 +++++++++++++------------------
 1 file changed, 16 insertions(+), 22 deletions(-)

diff --git a/drivers/video/backlight/mp3309c.c 
b/drivers/video/backlight/mp3309c.c
index d9b08f191999..57eb1bcc054d 100644
--- a/drivers/video/backlight/mp3309c.c
+++ b/drivers/video/backlight/mp3309c.c
@@ -224,10 +224,9 @@ static int pm3309c_parse_dt_node(struct mp3309c_chip *chip,
         */
        pdata->dimming_mode = DIMMING_ANALOG_I2C;
        if (device_property_present(dev, "pwms")) {
-               chip->pwmd = devm_pwm_get(chip->dev, NULL);
+               chip->pwmd = devm_pwm_get(dev, NULL);
                if (IS_ERR(chip->pwmd))
-                       return dev_err_probe(chip->dev, PTR_ERR(chip->pwmd),
-                                            "error getting pwm data\n");
+                       return dev_err_probe(dev, PTR_ERR(chip->pwmd), "error 
getting pwm data\n");
                pdata->dimming_mode = DIMMING_PWM;
                pwm_apply_args(chip->pwmd);
        }
@@ -245,11 +244,9 @@ static int pm3309c_parse_dt_node(struct mp3309c_chip *chip,
                num_levels = ANALOG_I2C_NUM_LEVELS;
 
                /* Enable GPIO used in I2C dimming mode only */
-               chip->enable_gpio = devm_gpiod_get(chip->dev, "enable",
-                                                  GPIOD_OUT_HIGH);
+               chip->enable_gpio = devm_gpiod_get(dev, "enable", 
GPIOD_OUT_HIGH);
                if (IS_ERR(chip->enable_gpio))
-                       return dev_err_probe(chip->dev,
-                                            PTR_ERR(chip->enable_gpio),
+                       return dev_err_probe(dev, PTR_ERR(chip->enable_gpio),
                                             "error getting enable gpio\n");
        } else {
                /*
@@ -267,8 +264,7 @@ static int pm3309c_parse_dt_node(struct mp3309c_chip *chip,
        }
 
        /* Fill brightness levels array */
-       pdata->levels = devm_kcalloc(chip->dev, num_levels,
-                                    sizeof(*pdata->levels), GFP_KERNEL);
+       pdata->levels = devm_kcalloc(dev, num_levels, sizeof(*pdata->levels), 
GFP_KERNEL);
        if (!pdata->levels)
                return -ENOMEM;
        if (device_property_present(dev, "brightness-levels")) {
@@ -287,8 +283,7 @@ static int pm3309c_parse_dt_node(struct mp3309c_chip *chip,
        if (ret)
                pdata->default_brightness = pdata->max_brightness;
        if (pdata->default_brightness > pdata->max_brightness) {
-               dev_err(chip->dev,
-                       "default brightness exceeds max brightness\n");
+               dev_err(dev, "default brightness exceeds max brightness\n");
                pdata->default_brightness = pdata->max_brightness;
        }
 
@@ -329,32 +324,33 @@ static int pm3309c_parse_dt_node(struct mp3309c_chip 
*chip,
 
 static int mp3309c_probe(struct i2c_client *client)
 {
-       struct mp3309c_platform_data *pdata = dev_get_platdata(&client->dev);
+       struct device *dev = &client->dev;
+       struct mp3309c_platform_data *pdata = dev_get_platdata(dev);
        struct mp3309c_chip *chip;
        struct backlight_properties props;
        struct pwm_state pwmstate;
        int ret;
 
        if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) {
-               dev_err(&client->dev, "failed to check i2c functionality\n");
+               dev_err(dev, "failed to check i2c functionality\n");
                return -EOPNOTSUPP;
        }
 
-       chip = devm_kzalloc(&client->dev, sizeof(*chip), GFP_KERNEL);
+       chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL);
        if (!chip)
                return -ENOMEM;
 
-       chip->dev = &client->dev;
+       chip->dev = dev;
 
        chip->regmap = devm_regmap_init_i2c(client, &mp3309c_regmap);
        if (IS_ERR(chip->regmap))
-               return dev_err_probe(&client->dev, PTR_ERR(chip->regmap),
+               return dev_err_probe(dev, PTR_ERR(chip->regmap),
                                     "failed to allocate register map\n");
 
        i2c_set_clientdata(client, chip);
 
        if (!pdata) {
-               pdata = devm_kzalloc(chip->dev, sizeof(*pdata), GFP_KERNEL);
+               pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
                if (!pdata)
                        return -ENOMEM;
 
@@ -371,11 +367,10 @@ static int mp3309c_probe(struct i2c_client *client)
        props.type = BACKLIGHT_RAW;
        props.power = FB_BLANK_UNBLANK;
        props.fb_blank = FB_BLANK_UNBLANK;
-       chip->bl = devm_backlight_device_register(chip->dev, "mp3309c",
-                                                 chip->dev, chip,
+       chip->bl = devm_backlight_device_register(dev, "mp3309c", dev, chip,
                                                  &mp3309c_bl_ops, &props);
        if (IS_ERR(chip->bl))
-               return dev_err_probe(chip->dev, PTR_ERR(chip->bl),
+               return dev_err_probe(dev, PTR_ERR(chip->bl),
                                     "error registering backlight device\n");
 
        /* In PWM dimming mode, enable pwm device */
@@ -387,8 +382,7 @@ static int mp3309c_probe(struct i2c_client *client)
                pwmstate.enabled = true;
                ret = pwm_apply_state(chip->pwmd, &pwmstate);
                if (ret)
-                       return dev_err_probe(chip->dev, ret,
-                                            "error setting pwm device\n");
+                       return dev_err_probe(dev, ret, "error setting pwm 
device\n");
        }
 
        chip->pdata->status = FIRST_POWER_ON;
-- 
2.43.0.rc1.1.gbec44491f096

Reply via email to