Re: [PATCH] drm/vc4: plane: check drm_gem_plane_helper_prepare_fb() return value

[Maira Canal]

Hi Simon,

On 12/16/23 11:15, Simon Ser wrote:

Bubble up any error to the caller.

Signed-off-by: Simon Ser <cont...@emersion.fr>
Cc: Maxime Ripard <mrip...@kernel.org>
Cc: Kees Cook <keesc...@chromium.org>
Cc: Dave Stevenson <dave.steven...@raspberrypi.com>

Reviewed-by: Maíra Canal <mca...@igalia.com>

Best Regards,
- Maíra

---
  drivers/gpu/drm/vc4/vc4_plane.c | 5 ++++-
  1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c
index 00e713faecd5..b8184374332c 100644
--- a/drivers/gpu/drm/vc4/vc4_plane.c
+++ b/drivers/gpu/drm/vc4/vc4_plane.c
@@ -1497,13 +1497,16 @@ static int vc4_prepare_fb(struct drm_plane *plane,
                          struct drm_plane_state *state)
  {
        struct vc4_bo *bo;
+       int ret;

if (!state->fb)

                return 0;

bo = to_vc4_bo(&drm_fb_dma_get_gem_obj(state->fb, 0)->base); - drm_gem_plane_helper_prepare_fb(plane, state);

+       ret = drm_gem_plane_helper_prepare_fb(plane, state);
+       if (ret)
+               return ret;

if (plane->state->fb == state->fb)

                return 0;