Hi Thomas,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-misc/drm-misc-next]
[also build test ERROR on drm-tip/drm-tip linus/master v6.8-rc2 next-20240202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    
https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/video-Add-helpers-for-decoding-screen_info/20240202-200314
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    
https://lore.kernel.org/r/20240202120140.3517-4-tzimmermann%40suse.de
patch subject: [PATCH v2 3/8] firmware/sysfb: Set firmware-framebuffer parent 
device
config: i386-buildonly-randconfig-002-20240203 
(https://download.01.org/0day-ci/archive/20240204/202402040214.gfutmkrc-...@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): 
(https://download.01.org/0day-ci/archive/20240204/202402040214.gfutmkrc-...@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <l...@intel.com>
| Closes: 
https://lore.kernel.org/oe-kbuild-all/202402040214.gfutmkrc-...@intel.com/

All errors (new ones prefixed by >>):

   drivers/firmware/sysfb.c: In function 'sysfb_init':
>> drivers/firmware/sysfb.c:104:8: error: too many arguments to function 
>> 'sysfb_create_simplefb'
      pd = sysfb_create_simplefb(si, &mode, parent);
           ^~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/firmware/sysfb.c:36:0:
   include/linux/sysfb.h:105:39: note: declared here
    static inline struct platform_device *sysfb_create_simplefb(const struct 
screen_info *si,
                                          ^~~~~~~~~~~~~~~~~~~~~


vim +/sysfb_create_simplefb +104 drivers/firmware/sysfb.c

    83  
    84  static __init int sysfb_init(void)
    85  {
    86          struct screen_info *si = &screen_info;
    87          struct device *parent;
    88          struct simplefb_platform_data mode;
    89          const char *name;
    90          bool compatible;
    91          int ret = 0;
    92  
    93          mutex_lock(&disable_lock);
    94          if (disabled)
    95                  goto unlock_mutex;
    96  
    97          sysfb_apply_efi_quirks();
    98  
    99          parent = sysfb_parent_dev(si);
   100  
   101          /* try to create a simple-framebuffer device */
   102          compatible = sysfb_parse_mode(si, &mode);
   103          if (compatible) {
 > 104                  pd = sysfb_create_simplefb(si, &mode, parent);
   105                  if (!IS_ERR(pd))
   106                          goto unlock_mutex;
   107          }
   108  
   109          /* if the FB is incompatible, create a legacy framebuffer 
device */
   110          if (si->orig_video_isVGA == VIDEO_TYPE_EFI)
   111                  name = "efi-framebuffer";
   112          else if (si->orig_video_isVGA == VIDEO_TYPE_VLFB)
   113                  name = "vesa-framebuffer";
   114          else if (si->orig_video_isVGA == VIDEO_TYPE_VGAC)
   115                  name = "vga-framebuffer";
   116          else if (si->orig_video_isVGA == VIDEO_TYPE_EGAC)
   117                  name = "ega-framebuffer";
   118          else
   119                  name = "platform-framebuffer";
   120  
   121          pd = platform_device_alloc(name, 0);
   122          if (!pd) {
   123                  ret = -ENOMEM;
   124                  goto unlock_mutex;
   125          }
   126  
   127          pd->dev.parent = parent;
   128  
   129          sysfb_set_efifb_fwnode(pd);
   130  
   131          ret = platform_device_add_data(pd, si, sizeof(*si));
   132          if (ret)
   133                  goto err;
   134  
   135          ret = platform_device_add(pd);
   136          if (ret)
   137                  goto err;
   138  
   139          goto unlock_mutex;
   140  err:
   141          platform_device_put(pd);
   142  unlock_mutex:
   143          mutex_unlock(&disable_lock);
   144          return ret;
   145  }
   146  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Reply via email to