On Wed, Aug 25, 2010 at 4:30 PM, Jerome Glisse <jglisse at redhat.com> wrote: > size given in resource is the exact size (not size - 1) >
NAK, the vtx resource size is size minus 1. See the accel code in the ddx and the code in r600 driver in mesa. Alex > Signed-off-by: Jerome Glisse <jglisse at redhat.com> > --- > ?drivers/gpu/drm/radeon/r600_cs.c | ? ?2 +- > ?1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/r600_cs.c > b/drivers/gpu/drm/radeon/r600_cs.c > index d886494..487a765 100644 > --- a/drivers/gpu/drm/radeon/r600_cs.c > +++ b/drivers/gpu/drm/radeon/r600_cs.c > @@ -1401,7 +1401,7 @@ static int r600_packet3_check(struct radeon_cs_parser > *p, > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?return -EINVAL; > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?} > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?offset = radeon_get_ib_value(p, idx+1+(i*7)+0); > - ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? size = radeon_get_ib_value(p, idx+1+(i*7)+1) > + 1; > + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? size = radeon_get_ib_value(p, idx+1+(i*7)+1); > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?if (p->rdev && (size + offset) > > radeon_bo_size(reloc->robj)) { > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?/* force size to size of the buffer */ > ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?dev_warn(p->dev, "vbo resource seems > too big (%d) for the bo (%ld)\n", > -- > 1.7.0.1 > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel >