Hi,
On 09.02.2024 16:39, Jeffrey Hugo wrote:
> On 2/7/2024 3:24 AM, Jacek Lawrynowicz wrote:
>> Issue IP reset before shutdown in order to
>> complete all upstream requests to the SOC.
>> Without this DevTLB is complaining about
>> incomplete transactions and NPU cannot resume from
>> suspend.
>> This problem is only happening on recent IFWI
>> releases.
>>
>> IP reset in rare corner cases can mess up PCI
>> configuration, so save it before the reset.
>> After this happens it is also impossible to
>> issue PLL requests and D0->D3->D0 cycle is needed
>> to recover the NPU. Add WP 0 request on power up,
>> so the PUNIT is always notified about NPU reset.
>>
>> Use D0/D3 cycle for recovery as it can recover
>> from failed IP reset and FLR cannot.
>>
>> Fixes: 3f7c0634926d ("accel/ivpu/37xx: Fix hangs related to MMIO reset")
>> Signed-off-by: Jacek Lawrynowicz <jacek.lawrynow...@linux.intel.com>
>> ---
>
> Reviewed-by: Jeffrey Hugo <quic_jh...@quicinc.com>
>
> Nit below
>
>> ret = ivpu_shutdown(vdev);
>> - if (ret) {
>> + if (ret)
>> ivpu_err(vdev, "Failed to shutdown VPU: %d\n", ret);
>
> In the two logs you add in this change, the log has "NPU". Here, there is
> "VPU". As far as I understand VPU is the old term and NPU is the new term
> therefore it seems like all the logs should be updated to use the new term
> for consistency. Outside of scope for this change though.
Ok, I will fix this in next patchset.
Thanks,
Jacek
