On Wed, Feb 21, 2024 at 10:41:28AM +0100, Thomas Zimmermann wrote:
> Framebuffer drivers for devices with dedicated backlight are supposed
> to set struct fb_info.bl_dev to the backlight's respective device. Use
> the value to match backlight and framebuffer in the backlight core code.

...

>       if (!bd->ops)
>               goto out;
> -     if (bd->ops->check_fb && !bd->ops->check_fb(bd, evdata->info))
> +     else if (bd->ops->check_fb && !bd->ops->check_fb(bd, info))

What's the point of adding redundant 'else'?

>               goto out;
> +#if IS_ENABLED(CONFIG_FB_BACKLIGHT)
> +     else if (info->bl_dev && info->bl_dev != bd)

Ditto.

> +             goto out;
> +#endif

-- 
With Best Regards,
Andy Shevchenko


Reply via email to