On Fri, Dec 8, 2023, at 01:52, Mina Almasry wrote:
> +static void *gve_rx_queue_mem_alloc(struct net_device *dev, int idx)
> +{
> + struct gve_per_rx_queue_mem_dqo *gve_q_mem;
...
> +
> + gve_q_mem = kvcalloc(1, sizeof(*gve_q_mem), GFP_KERNEL);
> + if (!gve_q_mem)
> + goto err;[minor comment] The structure does not seem overly large, even if you have an array here, I don't see why you would need the vmalloc type allocation for struct gve_per_rx_queue_mem_dqo. Arnd
