Re: [PATCH 09/43] drm/ast: Use fbdev-shmem

[Jocelyn Falempe]

Hi,

Thanks, it looks good to me.

Reviewed-by: Jocelyn Falempe <jfale...@redhat.com>

--

Jocelyn

On 12/03/2024 16:45, Thomas Zimmermann wrote:

Implement fbdev emulation with fbdev-shmem. Avoids the overhead of
fbdev-generic's additional shadow buffering. No functional changes.

Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
Cc: Dave Airlie <airl...@redhat.com>
Cc: Thomas Zimmermann <tzimmerm...@suse.de>
Cc: Jocelyn Falempe <jfale...@redhat.com>
---
  drivers/gpu/drm/ast/ast_drv.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/ast/ast_drv.c b/drivers/gpu/drm/ast/ast_drv.c
index 90bcb1eb9cd94..4fcab4304e176 100644
--- a/drivers/gpu/drm/ast/ast_drv.c
+++ b/drivers/gpu/drm/ast/ast_drv.c
@@ -32,7 +32,7 @@
  #include <drm/drm_aperture.h>
  #include <drm/drm_atomic_helper.h>
  #include <drm/drm_drv.h>
-#include <drm/drm_fbdev_generic.h>
+#include <drm/drm_fbdev_shmem.h>
  #include <drm/drm_gem_shmem_helper.h>
  #include <drm/drm_module.h>
  #include <drm/drm_probe_helper.h>
@@ -359,7 +359,7 @@ static int ast_pci_probe(struct pci_dev *pdev, const struct 
pci_device_id *ent)
        if (ret)
                return ret;

- drm_fbdev_generic_setup(drm, 32);

+       drm_fbdev_shmem_setup(drm, 32);

return 0;

  }