Hi,
On 2024/3/19 02:04, Laurent Pinchart wrote:
Hi Sui,
On Tue, Mar 19, 2024 at 12:42:41AM +0800, Sui Jingfeng wrote:
On 2024/3/19 00:06, Laurent Pinchart wrote:
Commit 00084f0c01bf ("drm: bridge: thc63lvd1024: Switch to use
of_graph_get_remote_node()") simplified the thc63lvd1024 driver by
replacing hand-rolled code with a helper function.
[...]
While doing so, it
created an error code path at probe time without any error message,
If this is a reason or a concern, then every drm bridges drivers will suffer
from
such a concern. Right?
Yes, bridge drivers (or any driver, really) should avoid failing probe
silently.
Yes, I agree with you that bridge drivers should avoid failing probe.
But the real problem that deserve to discuss is that is it really *silently* ?
The of_graph_get_remote_node() function do have debug prints on failure:
- pr_debug("no valid endpoint (%d, %d) for node %pOF\n", port, endpoint,
node);
- pr_debug("no valid remote node\n");
- pr_debug("not available for remote node\n");
So it is not really *silently*.
