Applied. Thanks!
On Sun, Apr 28, 2024 at 9:32 PM Zhou, Bob <[email protected]> wrote: > > [Public] > > Reviewed-by: Bob Zhou <[email protected]> > > Regards, > Bob > > -----Original Message----- > From: Dan Carpenter <[email protected]> > Sent: 2024年4月28日 20:57 > To: Zhou, Bob <[email protected]> > Cc: Deucher, Alexander <[email protected]>; Koenig, Christian > <[email protected]>; Pan, Xinhui <[email protected]>; David Airlie > <[email protected]>; Daniel Vetter <[email protected]>; Kuehling, Felix > <[email protected]>; Zhang, Hawking <[email protected]>; Guchun Chen > <[email protected]>; Ma, Le <[email protected]>; Lazar, Lijo > <[email protected]>; Sharma, Shashank <[email protected]>; > [email protected]; [email protected]; > [email protected]; [email protected] > Subject: [PATCH] drm/amdgpu: Fix signedness bug in > sdma_v4_0_process_trap_irq() > > The "instance" variable needs to be signed for the error handling to work. > > Fixes: b34ddc71267a ("drm/amdgpu: add error handle to avoid out-of-bounds") > Signed-off-by: Dan Carpenter <[email protected]> > --- > drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > index 101038395c3b..772604feb6ac 100644 > --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c > @@ -2017,7 +2017,7 @@ static int sdma_v4_0_process_trap_irq(struct > amdgpu_device *adev, > struct amdgpu_irq_src *source, > struct amdgpu_iv_entry *entry) { > - uint32_t instance; > + int instance; > > DRM_DEBUG("IH: SDMA trap\n"); > instance = sdma_v4_0_irq_id_to_seq(entry->client_id); > -- > 2.43.0 >
