On 28/05/24 02:08, Andy Shevchenko wrote: > On Mon, May 27, 2024 at 11:37:20PM +0300, Andy Shevchenko wrote: >> On Sun, May 26, 2024 at 11:39:33PM +0530, Devarsh Thakkar wrote: > > ... > >>> +MODULE_LICENSE("GPL"); >> >> modpost validator won't be happy about this, i.e. missing >> MODULE_DESCRIPTION(). > > And obviously + module.h in the inclusion block. > The module.h is already included under include/kunit/test.h and that's the reason compiler did not give any error. But I can still include it under math.h for better readability as you suggested as anyway compiler will not re-include if already included by another header file. Also I see we were missing a dependency between math_kunit and kunit modules, so adding a dependency there too. Regards Devarsh
- [PATCH v9 00/10] Add V4L2 M2M Driver for E5010 JPEG Encode... Devarsh Thakkar
- [PATCH v9 06/10] math.h: Add macros for rounding to c... Devarsh Thakkar
- Re: [PATCH v9 06/10] math.h: Add macros for round... Andy Shevchenko
- Re: [PATCH v9 06/10] math.h: Add macros for r... Devarsh Thakkar
- Re: [PATCH v9 06/10] math.h: Add macros f... Andy Shevchenko
- [PATCH v9 07/10] lib: add basic KUnit test for lib/ma... Devarsh Thakkar
- Re: [PATCH v9 07/10] lib: add basic KUnit test fo... Andy Shevchenko
- Re: [PATCH v9 07/10] lib: add basic KUnit tes... Andy Shevchenko
- Re: [PATCH v9 07/10] lib: add basic KUnit... Devarsh Thakkar
- Re: [PATCH v9 07/10] lib: add basic ... Andy Shevchenko
- Re: [PATCH v9 07/10] lib: add basic KUnit tes... Devarsh Thakkar
- Re: [PATCH v9 07/10] lib: add basic KUnit... Andy Shevchenko
- [PATCH v9 08/10] lib: math_kunit: Add tests for new m... Devarsh Thakkar
- [PATCH v9 09/10] media: imagination: Round to closest... Devarsh Thakkar
- [PATCH v9 10/10] gpu: ipu-v3: Use generic macro for r... Devarsh Thakkar