Re: [PATCH v2 04/14] drm/msm/hdmi: set infoframes on all pre_enable calls

[Jessica Zhang]

On 5/22/2024 3:50 AM, Dmitry Baryshkov wrote:
In consequent modeset calls, the atomic_pre_enable() will be called
several times without calling atomic_post_disable() inbetween. Thus

Hi Dmitry,

Just wondering, where are you seeing multiple pre_enable() calls without 
a post_disable() happening?

IIRC, the msm commit_tail always calls commit_modeset_disables() before 
the commit_modeset_enables(). Also, doesn't the pre_enable() and 
post_disable() only happen once for bringing up/down the bridge?

Thanks,

Jessica Zhang

iframes will not be updated for the next mode. Fix this by setting the
iframe outside of the !power_on check.

Signed-off-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org>
---
  drivers/gpu/drm/msm/hdmi/hdmi_bridge.c | 9 +++++----
  1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c 
b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c
index 3c6121c57b01..fb99328107dd 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_bridge.c
@@ -133,10 +133,11 @@ static void msm_hdmi_bridge_atomic_pre_enable(struct 
drm_bridge *bridge,
                msm_hdmi_phy_resource_enable(phy);
                msm_hdmi_power_on(bridge);
                hdmi->power_on = true;
-               if (hdmi->hdmi_mode) {
-                       msm_hdmi_config_avi_infoframe(hdmi);
-                       msm_hdmi_audio_update(hdmi);
-               }
+       }
+
+       if (hdmi->hdmi_mode) {
+               msm_hdmi_config_avi_infoframe(hdmi);
+               msm_hdmi_audio_update(hdmi);
        }
  
  	msm_hdmi_phy_powerup(phy, hdmi->pixclock);

--
2.39.2