On 06/14/2010 04:07 PM, Stefan Richter wrote: > On 14 Jun, Justin P. Mattock wrote: >> On 06/14/2010 02:47 PM, Edward Shishkin wrote: >>> Whitespaces should be removed. >>> I recommend quilt package for managing patches: >>> "quilt refresh --strip-trailing-whitespace" is your friend.. >> >> o.k. I resent this.. fixed the whitespace(hopefully) >> and add your Acked to it. >> as for quilt I'll have to look into that.. >> (using a lfs system, so if the sourcecode is easy >> to deal with(build), then it's a good but if it becomes >> a nightmare maybe not!!). > > Since you appear to generate the patches with git, you can use "git diff > --check [...]" for some basic whitespace checks (additions of trailing > space, additions of space before tab). For more extensive checks, try > "git diff [...] | scripts/checkpatch.pl -". Check this before you > commit. If you committed already, "git commit --amend [-a] [...]" lets > you alter the very last commit of course.
Thanks for the info on this, copied it down in my book of commands... Justin P. Mattock