These variables are only used inside efifb_probe().
Afterwards they are using memory unnecessarily.

Signed-off-by: Thomas Weißschuh <li...@weissschuh.net>
---
 drivers/video/fbdev/efifb.c | 36 ++++++++++++++++++------------------
 1 file changed, 18 insertions(+), 18 deletions(-)

diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
index 8dd82afb3452..8bfe0ccbc67a 100644
--- a/drivers/video/fbdev/efifb.c
+++ b/drivers/video/fbdev/efifb.c
@@ -52,24 +52,6 @@ struct efifb_par {
        resource_size_t size;
 };
 
-static struct fb_var_screeninfo efifb_defined = {
-       .activate               = FB_ACTIVATE_NOW,
-       .height                 = -1,
-       .width                  = -1,
-       .right_margin           = 32,
-       .upper_margin           = 16,
-       .lower_margin           = 4,
-       .vsync_len              = 4,
-       .vmode                  = FB_VMODE_NONINTERLACED,
-};
-
-static struct fb_fix_screeninfo efifb_fix = {
-       .id                     = "EFI VGA",
-       .type                   = FB_TYPE_PACKED_PIXELS,
-       .accel                  = FB_ACCEL_NONE,
-       .visual                 = FB_VISUAL_TRUECOLOR,
-};
-
 static int efifb_setcolreg(unsigned regno, unsigned red, unsigned green,
                           unsigned blue, unsigned transp,
                           struct fb_info *info)
@@ -357,6 +339,24 @@ static int efifb_probe(struct platform_device *dev)
        char *option = NULL;
        efi_memory_desc_t md;
 
+       struct fb_var_screeninfo efifb_defined = {
+               .activate               = FB_ACTIVATE_NOW,
+               .height                 = -1,
+               .width                  = -1,
+               .right_margin           = 32,
+               .upper_margin           = 16,
+               .lower_margin           = 4,
+               .vsync_len              = 4,
+               .vmode                  = FB_VMODE_NONINTERLACED,
+       };
+
+       struct fb_fix_screeninfo efifb_fix = {
+               .id                     = "EFI VGA",
+               .type                   = FB_TYPE_PACKED_PIXELS,
+               .accel                  = FB_ACCEL_NONE,
+               .visual                 = FB_VISUAL_TRUECOLOR,
+       };
+
        /*
         * If we fail probing the device, the kernel might try a different
         * driver. We get a copy of the attached screen_info, so that we can

-- 
2.46.0

Reply via email to