On Tue, Sep 24, 2024 at 01:42:01PM +0200, AngeloGioacchino Del Regno wrote:
> Il 24/09/24 12:31, Macpaul Lin ha scritto:
> > The display node in mt8195.dtsi was triggering a CHECK_DTBS error due
> > to an excessively long 'clocks' property:
> > display@14f06000: clocks: [[31, 14], [31, 43], [31, 44]] is too long
> >
> > To resolve this issue, add "maxItems: 3" to the 'clocks' property in
> > the DT schema.
> >
> > Fixes: 4ed545e7d100 ("dt-bindings: display: mediatek: disp: split each
> > block to individual yaml")
> > Signed-off-by: Macpaul Lin <macpaul....@mediatek.com>
> > ---
> > .../devicetree/bindings/display/mediatek/mediatek,split.yaml | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml
> > index e4affc854f3d..42d2d483cc29 100644
> > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml
> > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,split.yaml
> > @@ -57,6 +57,7 @@ properties:
> > clocks:
> > items:
> > - description: SPLIT Clock
>
> That's at least confusing (granted that it works) - either add a description
> for
> each clock and then set `minItems: 1` (preferred), or remove this "SPLIT
> Clock"
> description and allow a maximum of 3 clocks.
>
> Removing the description can be done - IMO - because "SPLIT Clock" is, well,
> saying that the SPLIT block gets a SPLIT clock ... stating the obvious,
> anyway.Right, but what are the other two new clocks? Are they as obvious? There's no clock-names here to give any more information as to what the other clocks are supposed to be. Kinda unrelated, but I think that "SPLIT Clock" probably isn't what the name of the clock in the IP block is anyway, sounds more like the name for it on the provider end..
signature.asc
Description: PGP signature
