>-----Original Message-----
>From: Dmitry Baryshkov <dmitry.barysh...@linaro.org>
>Sent: Thursday, September 26, 2024 8:58 PM
>To: Hermes Wu (吳佳宏) <hermes...@ite.com.tw>
>Cc: Kenneth Hung (洪家倫) <kenneth.h...@ite.com.tw>; Andrzej Hajda
><andrzej.ha...@intel.com>; Neil Armstrong <neil.armstr...@linaro.org>; Robert
>Foss <rf...@kernel.org>; Laurent Pinchart <laurent.pinch...@ideasonboard.com>;
>Jonas Karlman <jo...@kwiboo.se>; Jernej Skrabec <jernej.skra...@gmail.com>;
>Maarten Lankhorst <maarten.lankho...@linux.intel.com>; Maxime Ripard
><mrip...@kernel.org>; Thomas Zimmermann <tzimmerm...@suse.de>; David Airlie
><airl...@gmail.com>; Simona Vetter <sim...@ffwll.ch>; AngeloGioacchino Del
>Regno <angelogioacchino.delre...@collabora.com>; Allen Chen
><allen.c...@ite.com.tw>; open list:DRM DRIVERS
><dri-devel@lists.freedesktop.org>; open list <linux-ker...@vger.kernel.org>
>Subject: Re: [PATCH v4 11/11] drm/bridge: it6505: Add aux i2c functionality
>
>On Thu, Sep 26, 2024 at 03:51:34PM GMT, Hermes Wu wrote:
>> From: Hermes Wu <hermes...@ite.com.tw>
>>
>> Add aux-i2c operaction in order to support the MCCS function.
>
>Brevity is the soul of wit. However in the commit message we appreciate more
>details. Is it enough to get monitor control to work? Or is there anything
>left to be implemented?
In drm_dp_helper, drm_dp_i2c_xfer() pack I2C request into sequence of AUX
request.
it6505_aux_i2c_operation() is implement to match drm_dp_i2c_xfer() behavior
>>
>>
>> Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
>
>This is definitely not a fix.
will remove.
>> Signed-off-by: Hermes Wu <hermes...@ite.com.tw>
>> ---
>> drivers/gpu/drm/bridge/ite-it6505.c | 177
>> +++++++++++++++++++++++++++-
>> 1 file changed, 175 insertions(+), 2 deletions(-)
>
>--
>With best wishes
>Dmitry
>
BR,
Hermes
