RE: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.

[Keith Zhao]

> -----Original Message-----
> From: Uwe Kleine-König <u.kleine-koe...@baylibre.com>
> Sent: 2024年11月20日 22:56
> To: Keith Zhao <keith.z...@starfivetech.com>
> Cc: devicet...@vger.kernel.org; dri-devel@lists.freedesktop.org;
> andrzej.ha...@intel.com; neil.armstr...@linaro.org; rf...@kernel.org;
> laurent.pinch...@ideasonboard.com; jernej.skra...@gmail.com;
> maarten.lankho...@linux.intel.com; mrip...@kernel.org;
> tzimmerm...@suse.de; airl...@gmail.com; sim...@ffwll.ch;
> r...@kernel.org; krzk...@kernel.org; conor...@kernel.org;
> h...@rock-chips.com; he...@sntech.de; andy....@rock-chips.com; William Qiu
> <william....@starfivetech.com>; Xingyu Wu <xingyu...@starfivetech.com>;
> ker...@esmil.dk; paul.walms...@sifive.com; pal...@dabbelt.com;
> a...@eecs.berkeley.edu; p.za...@pengutronix.de; Changhuang Liang
> <changhuang.li...@starfivetech.com>; Jack Zhu <jack....@starfivetech.com>;
> linux-ker...@vger.kernel.org
> Subject: Re: [PATCH v5 3/9] drm: bridge: inno-hdmi: add inno bridge driver.
> 
> Hello,
> 
> On Wed, Nov 20, 2024 at 02:18:42PM +0800, keith zhao wrote:
> > +struct platform_driver inno_hdmi_driver = {
> > +   .probe  = inno_hdmi_rockchip_probe,
> > +   .remove_new = inno_hdmi_rockchip_remove,
> 
> Please use .remove instead of .remove_new.
> 
Thank you for the clarification regarding .remove_new. 
I understand that it's a relic and that new drivers should implement .remove().

I have a question. One of the changes in this patch is to rename some function 
interfaces. 
The original code is like this. 

struct platform_driver inno_hdmi_driver = {
        .probe  = inno_hdmi_probe,
        .remove_new = inno_hdmi_remove,
        .driver = {
                .name = "innohdmi-rockchip",
                .of_match_table = inno_hdmi_dt_ids,
        },
};

Rename inno_hdmi_probe and inno_hdmi_remove
struct platform_driver inno_hdmi_driver = {
        .probe  = inno_hdmi_rockchip_probe,
        .remove_new = inno_hdmi_rockchip_remove,
        .driver = {
                .name = "innohdmi-rockchip",
                .of_match_table = inno_hdmi_dt_ids,
        },
};
Based on the principle of maintaining consistency, 
does it(remove_new) need to be changed?

Thanks

> Best regards
> Uwe