Normally the console is already suspended when the graphic driver
suspend callback is called, but if the parameter no_console_suspend
is set, it might still be active.
So call console_stop()/console_start() in the suspend/resume
callbacks, to make sure it won't try to write to the framebuffer
while the graphic driver is suspended.

Signed-off-by: Jocelyn Falempe <jfale...@redhat.com>
Reviewed-by: John Ogness <john.ogn...@linutronix.de>
Acked-by: Petr Mladek <pmla...@suse.com>
Reviewed-by: Thomas Zimmermann <tzimmerm...@suse.de>
---


v6:
 * Use console_stop() and console_start() in the suspend/resume callback (Petr 
Mladek).

 drivers/gpu/drm/clients/drm_log.c | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/drivers/gpu/drm/clients/drm_log.c 
b/drivers/gpu/drm/clients/drm_log.c
index 5a995742aec5..d5f9c679f2c0 100644
--- a/drivers/gpu/drm/clients/drm_log.c
+++ b/drivers/gpu/drm/clients/drm_log.c
@@ -310,10 +310,30 @@ static int drm_log_client_hotplug(struct drm_client_dev 
*client)
        return 0;
 }
 
+static int drm_log_client_suspend(struct drm_client_dev *client, bool 
_console_lock)
+{
+       struct drm_log *dlog = client_to_drm_log(client);
+
+       console_stop(&dlog->con);
+
+       return 0;
+}
+
+static int drm_log_client_resume(struct drm_client_dev *client, bool 
_console_lock)
+{
+       struct drm_log *dlog = client_to_drm_log(client);
+
+       console_start(&dlog->con);
+
+       return 0;
+}
+
 static const struct drm_client_funcs drm_log_client_funcs = {
        .owner          = THIS_MODULE,
        .unregister     = drm_log_client_unregister,
        .hotplug        = drm_log_client_hotplug,
+       .suspend        = drm_log_client_suspend,
+       .resume         = drm_log_client_resume,
 };
 
 static void drm_log_write_thread(struct console *con, struct 
nbcon_write_context *wctxt)
-- 
2.47.1

Reply via email to