Hi Biju,
Thank you for the patch.
On Tue, Oct 22, 2024 at 09:24:23AM +0100, Biju Das wrote:
> The DPI_OE bit is removed from the latest RZ/G2UL and RZ/G2L hardware
> manual. So, drop this macro.
>
> Fixes: b330f1480172 ("drm: renesas: rz-du: Add RZ/G2UL DU Support")
> Signed-off-by: Biju Das <biju.das...@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
> ---
> v1->v2:
> * Added Fixes tag.
> ---
> drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c
> b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c
> index c4c1474d487e..6e7aac6219be 100644
> --- a/drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c
> +++ b/drivers/gpu/drm/renesas/rz-du/rzg2l_du_crtc.c
> @@ -28,7 +28,6 @@
> #include "rzg2l_du_vsp.h"
>
> #define DU_MCR0 0x00
> -#define DU_MCR0_DPI_OE BIT(0)
> #define DU_MCR0_DI_EN BIT(8)
>
> #define DU_DITR0 0x10
> @@ -217,14 +216,9 @@ static void rzg2l_du_crtc_put(struct rzg2l_du_crtc
> *rcrtc)
>
> static void rzg2l_du_start_stop(struct rzg2l_du_crtc *rcrtc, bool start)
> {
> - struct rzg2l_du_crtc_state *rstate =
> to_rzg2l_crtc_state(rcrtc->crtc.state);
> struct rzg2l_du_device *rcdu = rcrtc->dev;
> - u32 val = DU_MCR0_DI_EN;
>
> - if (rstate->outputs & BIT(RZG2L_DU_OUTPUT_DPAD0))
> - val |= DU_MCR0_DPI_OE;
> -
> - writel(start ? val : 0, rcdu->mmio + DU_MCR0);
> + writel(start ? DU_MCR0_DI_EN : 0, rcdu->mmio + DU_MCR0);
> }
>
> static void rzg2l_du_crtc_start(struct rzg2l_du_crtc *rcrtc)
--
Regards,
Laurent Pinchart
