On 12/18/2024 4:28 AM, Mirsad Todorovac wrote:
> The static analyser tool gave the following advice:
>
> ./drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:1266:7-14: WARNING opportunity for
> kmemdup
>
> → 1266 tmp = kmalloc(used_size, GFP_KERNEL);
> 1267 if (!tmp)
> 1268 return -ENOMEM;
> 1269
> → 1270 memcpy(tmp, &host_telemetry->body.error_count, used_size);
>
> Replacing kmalloc() + memcpy() with kmemdump() doesn't change semantics.
> Original code works without fault, so this is not a bug fix but proposed
> improvement.
>
> Link: https://lwn.net/Articles/198928/
> Fixes: 84a2947ecc85c ("drm/amdgpu: Implement virt req_ras_err_count")
> Cc: Alex Deucher <alexander.deuc...@amd.com>
> Cc: "Christian König" <christian.koe...@amd.com>
> Cc: Xinhui Pan <xinhui....@amd.com>
> Cc: David Airlie <airl...@gmail.com>
> Cc: Simona Vetter <sim...@ffwll.ch>
> Cc: Zhigang Luo <zhigang....@amd.com>
> Cc: Victor Skvortsov <victor.skvort...@amd.com>
> Cc: Hawking Zhang <hawking.zh...@amd.com>
> Cc: Lijo Lazar <lijo.la...@amd.com>
> Cc: Yunxiang Li <yunxiang...@amd.com>
> Cc: Jack Xiao <jack.x...@amd.com>
> Cc: Vignesh Chander <vignesh.chan...@amd.com>
> Cc: Danijel Slivka <danijel.sli...@amd.com>
> Cc: amd-...@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-ker...@vger.kernel.org
> Signed-off-by: Mirsad Todorovac <mtodorova...@gmail.com>
Reviewed-by: Lijo Lazar <lijo.la...@amd.com>
Thanks,
Lijo
> ---
> v1:
> initial version.
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> index c704e9803e11..0af469ec6fcc 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> @@ -1263,12 +1263,10 @@ static int amdgpu_virt_cache_host_error_counts(struct
> amdgpu_device *adev,
> if (used_size > (AMD_SRIOV_RAS_TELEMETRY_SIZE_KB << 10))
> return 0;
>
> - tmp = kmalloc(used_size, GFP_KERNEL);
> + tmp = kmemdup(&host_telemetry->body.error_count, used_size, GFP_KERNEL);
> if (!tmp)
> return -ENOMEM;
>
> - memcpy(tmp, &host_telemetry->body.error_count, used_size);
> -
> if (checksum != amd_sriov_msg_checksum(tmp, used_size, 0, 0))
> goto out;
>
