On Sat, Jan 04, 2025 at 05:43:54AM +0800, Kuan-Wei Chiu wrote: > Hi Dmitry, > > On Fri, Jan 03, 2025 at 08:14:20PM +0200, Dmitry Baryshkov wrote: > > On Sat, Jan 04, 2025 at 12:17:58AM +0800, Yu-Chun Lin wrote: > > > Delete one line break to make the format correct, resolving the > > > following warning during a W=1 build: > > > > > > >> drivers/gpu/drm/tests/drm_kunit_helpers.c:324: warning: bad line: for > > > >> a KUnit test > > > > > > Reported-by: kernel test robot <l...@intel.com> > > > Closes: > > > https://lore.kernel.org/oe-kbuild-all/202501032001.o6wy1vcw-...@intel.com/ > > > Reviewed-by: Kuan-Wei Chiu <visitor...@gmail.com> > > > > Reviewed where? > > > Yu-Chun is a newcomer looking to contribute to Linux and asked for my > help. As suggested in the last section of [1], she asked me to review > her patch privately before sending it to the public mailing list and > include my Reviewed-by tag. This improves patch quality and reduces > the maintainer's workload by minimizing potential issues.
Good, thanks for the explanation. It's perfectly fine, just wanted to be sure that this is what actually happened. > > Although I'm not a DRM developer, I have been contributing to Linux for > some time and wanted to provide support. > > [1]: Documentation/process/researcher-guidelines.rst > > > > Tested-by: Kuan-Wei Chiu <visitor...@gmail.com> > > > Signed-off-by: Yu-Chun Lin <eleanor...@gmail.com> > > > --- > > > drivers/gpu/drm/tests/drm_kunit_helpers.c | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > > Reviewed-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org> > > > Thanks for your review! > > Regards, > Kuan-Wei -- With best wishes Dmitry