Il 14/01/25 06:49, Paul-pl Chen (陳柏霖) ha scritto:
Hi Rob
Thanks for the advice.
The root cause of the erroneous log message is due to missing power/clock
dependencies.
Once the MTK clock/power header file is upstreamed,
The mt8196-clk/power.h filenames are anyway wrong for upstream.... :-)
Cheers,
Angelo
we will include a reference link in the next version of the upstream series
submission.
Best, Paul-pl Chen
-----Original Message-----
From: Rob Herring (Arm) <r...@kernel.org>
Sent: Friday, January 10, 2025 9:54 PM
To: Paul-pl Chen (陳柏霖) <paul-pl.c...@mediatek.com>
Cc: conor...@kernel.org; Singo Chang (張興國) <singo.ch...@mediatek.com>; Sunny Shen (沈姍姍) <sunny.s...@mediatek.com>;
chunkuang...@kernel.org; Project_Global_Chrome_Upstream_Group <project_global_chrome_upstream_gr...@mediatek.com>;
fs...@chromium.org; Sirius Wang (王皓昱) <sirius.w...@mediatek.com>; dri-devel@lists.freedesktop.org;
matthias....@gmail.com; linux-ker...@vger.kernel.org; devicet...@vger.kernel.org; Xiandong Wang (王先冬)
<xiandong.w...@mediatek.com>; treapk...@chromium.org; Nancy Lin (林欣螢) <nancy....@mediatek.com>;
linux-media...@lists.infradead.org; p.za...@pengutronix.de; Jason-JH Lin (林睿祥) <jason-jh....@mediatek.com>;
AngeloGioacchino Del Regno <angelogioacchino.delre...@collabora.com>; linux-arm-ker...@lists.infradead.org;
krzk...@kernel.org
Subject: Re: [PATCH 03/12] dt-bindings: display: mediatek: add EXDMA yaml for
MT8196
External email : Please do not click links or open attachments until you have
verified the sender or the content.
On Fri, 10 Jan 2025 20:33:59 +0800, paul-pl.chen wrote:
From: "Paul-pl.Chen" <paul-pl.c...@mediatek.com>
Add mediatek,exdma.yaml to support EXDMA for MT8196.
Signed-off-by: Paul-pl.Chen <paul-pl.c...@mediatek.com>
---
The header used in examples:
#include <dt-bindings/clock/mt8196-clk.h> #include
<dt-bindings/power/mt8196-power.h>
are not upstreamed yet.
It will be sent by related owner soon.
---
.../display/mediatek/mediatek,exdma.yaml | 77 +++++++++++++++++++
1 file changed, 77 insertions(+)
create mode 100644
Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.yaml
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.example.dts:18:18:
fatal error: dt-bindings/clock/mt8196-clk.h: No such file or directory
18 | #include <dt-bindings/clock/mt8196-clk.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.dtbs:131:
Documentation/devicetree/bindings/display/mediatek/mediatek,exdma.example.dtb]
Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1506:
dt_binding_check] Error 2
make: *** [Makefile:251: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250110123835.2719824-5-paul-pl.c...@mediatek.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above error(s),
then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note that
DT_SCHEMA_FILES can be set to your schema file to speed up checking your
schema. However, it must be unset to test all examples with your schema.
