On Tue, Feb 04, 2025 at 04:10:37PM +0800, Pin-yen Lin wrote: > Hi Hermes, > > On Tue, Feb 4, 2025 at 11:49 AM <hermes...@ite.com.tw> wrote: > > > > Hi > > > > > >-----Original Message----- > > >From: Dmitry Baryshkov <dmitry.barysh...@linaro.org> > > >Sent: Tuesday, February 4, 2025 1:28 AM > > >To: Hermes Wu (吳佳宏) <hermes...@ite.com.tw> > > >Cc: Andrzej Hajda <andrzej.ha...@intel.com>; Neil Armstrong > > ><neil.armstr...@linaro.org>; Robert Foss <rf...@kernel.org>; Laurent > > >Pinchart <laurent.pinch...@ideasonboard.com>; Jonas Karlman > > ><jo...@kwiboo.se>; Jernej Skrabec <jernej.skra...@gmail.com>; Maarten > > >Lankhorst <maarten.lankho...@linux.intel.com>; Maxime Ripard > > ><mrip...@kernel.org>; Thomas Zimmermann <tzimmerm...@suse.de>; David > > >Airlie <airl...@gmail.com>; Simona Vetter <sim...@ffwll.ch>; > > >treapk...@chromium.org; dri-devel@lists.freedesktop.org; > > >linux-ker...@vger.kernel.org; Pet Weng (翁玉芬) <pet.w...@ite.com.tw>; > > >Kenneth Hung (洪家倫) <kenneth.h...@ite.com.tw> > > >Subject: Re: [PATCH v2] drm/bridge: it6505: support hdmi_codec_ops for > > >audio stream setup > > > > > >On Mon, Feb 03, 2025 at 02:04:30PM +0800, Hermes Wu via B4 Relay wrote: > > >> From: Hermes Wu <hermes...@ite.com.tw> > > >> > > >> For supporting audio form I2S to DP audio data sub stream. > > >> Add hdmi_audio callbacks to drm_bridge_funcs for the HDMI codec > > >> framework. The DRM_BRIDGE_OP_HDMI flag in bridge.ops must be set, and > > >> hdmi_write_infoframe and hdmi_clear_infoframe are necessary for the > > >> drm_bridge_connector to enable the HDMI codec. > > > > > >Please split this into two commits: one adding OP_HDMI, second one adding > > >audio support. > > > > This will need send patches with cover letter, should I keep patch version > > or reset it? > > I would bump to v3 in this case.
Definitely. -- With best wishes Dmitry
